Gengar shadow claw/dark pulse or sucker punch/shadow ball?

None. They both have sub-optimal movesets.

Shadow Claw wrecks and I believe Dark Pukse is faster which is good if you dodge. Sucker Punch has much higher EPS though which will charge Shadow Ball more quickly for huge STAB damage. I'd go with Sucker Punch